[MINOR][DOCS] Replace DataFrame with Dataset in Javadoc.
#11675
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @liancheng . |
|
Test build #52996 has finished for PR 11675 at commit
|
| @@ -66,7 +66,7 @@ | |||
| * RowFactory.create(0, "Hi I heard about Spark", 3.0), | |||
| * RowFactory.create(1, "I wish Java could use case classes", 4.0), | |||
| * RowFactory.create(2, "Logistic regression models are neat", 4.0))); | |||
| * DataFrame df = jsql.createDataFrame(rowRDD, schema); | |||
| * Dataset<Row> dataset = jsql.createDataFrame(rowRDD, schema); | |||
There was a problem hiding this comment.
One minor thing, we usually use ds instead of dataset to name a temporary Dataset in example code. But it's OK here.
|
LGTM, merging to master. Thanks for fixing this! |
|
Oh, thank you, @liancheng ! |
jeanlyn
pushed a commit
to jeanlyn/spark
that referenced
this pull request
Mar 17, 2016
## What changes were proposed in this pull request? SPARK-13817 (PR apache#11656) replaces `DataFrame` with `Dataset` from Java. This PR fixes the remaining broken links and sample Java code in `package-info.java`. As a result, it will update the following Javadoc. * http://spark.apache.org/docs/latest/api/java/org/apache/spark/ml/attribute/package-summary.html * http://spark.apache.org/docs/latest/api/java/org/apache/spark/ml/feature/package-summary.html ## How was this patch tested? Manual. Author: Dongjoon Hyun <[email protected]> Closes apache#11675 from dongjoon-hyun/replace_dataframe_with_dataset_in_javadoc.
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
## What changes were proposed in this pull request? SPARK-13817 (PR apache#11656) replaces `DataFrame` with `Dataset` from Java. This PR fixes the remaining broken links and sample Java code in `package-info.java`. As a result, it will update the following Javadoc. * http://spark.apache.org/docs/latest/api/java/org/apache/spark/ml/attribute/package-summary.html * http://spark.apache.org/docs/latest/api/java/org/apache/spark/ml/feature/package-summary.html ## How was this patch tested? Manual. Author: Dongjoon Hyun <[email protected]> Closes apache#11675 from dongjoon-hyun/replace_dataframe_with_dataset_in_javadoc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
SPARK-13817 (PR #11656) replaces
DataFramewithDatasetfrom Java. This PR fixes the remaining broken links and sample Java code inpackage-info.java. As a result, it will update the following Javadoc.How was this patch tested?
Manual.